Skip to content

ci: configure vaadin-dev as optional dependency #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paodb merged 1 commit into from
Jan 21, 2026
Merged

ci: configure vaadin-dev as optional dependency #193

paodb merged 1 commit into from
Jan 21, 2026

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 21, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated dependency configuration to mark a development dependency as optional, reducing build footprint.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026 •
edited
Loading

Walkthrough

Maven POM configuration updated to mark the vaadin-dev dependency as optional within the v25 profile. One line added to the dependency declaration.

Changes

Cohort / File(s) Summary
Maven Dependency Configuration
pom.xml		 Added <optional>true</optional> element to vaadin-dev dependency in profile v25, marking it as an optional transitive dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: marking the vaadin-dev dependency as optional in the Maven POM configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@javier-godoy javier-godoy requested a review from paodb January 21, 2026 18:18
@javier-godoy javier-godoy marked this pull request as ready for review January 21, 2026 18:18
@paodb paodb merged commit b746455 into master Jan 21, 2026
4 checks passed
@paodb paodb deleted the javier-godoy-patch-1 branch January 21, 2026 19:13
@javier-godoy javier-godoy mentioned this pull request Jan 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paodb paodb paodb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javier-godoy @paodb